OpenTimelineIO
OpenTimelineIO copied to clipboard
CMX 3600 premiere style
Fixes
[1178] Premiere style for cmx3600
Summary.
Adds support for Premiere style for cmx3600 to limit the auto added comments that are added per clip when writing out an EDL.
Tests.
No new tests were added but the below is failing when running make test yet nearest_valid_timecode_rate seem like it should be available from the C++ class definition:

Additionally, when I attempt to run make lint I get this error even though pydocstyle is in my venv:

Codecov Report
Merging #1199 (3609d52) into main (7f3b381) will decrease coverage by
0.00%. The diff coverage is100.00%.
@@ Coverage Diff @@
## main #1199 +/- ##
==========================================
- Coverage 86.08% 86.07% -0.01%
==========================================
Files 191 191
Lines 19228 19226 -2
Branches 2292 2292
==========================================
- Hits 16552 16549 -3
Misses 2123 2123
- Partials 553 554 +1
| Flag | Coverage Δ | |
|---|---|---|
| unittests | 86.07% <100.00%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
| Impacted Files | Coverage Δ | |
|---|---|---|
| ...opentimelineio/opentimelineio/adapters/cmx_3600.py | 85.46% <100.00%> (-0.03%) |
:arrow_down: |
| ...c/py-opentimelineio/opentimelineio/adapters/svg.py | 90.19% <0.00%> (-0.22%) |
:arrow_down: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact),ø = not affected,? = missing dataPowered by Codecov. Last update 7f3b381...3609d52. Read the comment docs.
Oops, sorry, one other note - would you mind adding a unittest to check the behavior? Here is an example of the unittest for the nucoda style:
@douglascomet This looks ready to merge, did you have any thoughts about @reinecke's request for a test?
Hi, @douglascomet ! Seems like this PR has been stuck on a failing test run for some time. In fact I'm unable to re-run it. Would you mind re-basing your branch and pushing the updates again for the tests to update?
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: douglascomet / name: Doug Halley (16607cd0905e491487eba2541d549c0ff908f25d, a415c438b4e15ef80503a581c6d75f1f0b9fca8e)
@apetrynet, thanks to your help we have resolved all the CI issues this PR was having!
Thank you for your contribution @douglascomet !