OpenRV icon indicating copy to clipboard operation
OpenRV copied to clipboard

717: Fix OUTPUT path of windows openssl cmake custom command

Open herronelou opened this issue 8 months ago • 1 comments

Linked issues

#717

Summarize your change.

The custom command's OUTPUT was pointing at the RV_STAGE_LIB_DIR, however the copy commands below were copying the files to the RV_STAGE_BIN_DIR (LIB vs BIN), always resulting in a warning during build:

       "C:\OpenRV\_build\cmake\dependencies\dependencies.vcxproj" (default target) (1) ->
       "C:\OpenRV\_build\cmake\dependencies\RV_DEPS_OPENSSL-stage-target.vcxproj" (default target)
       (15) ->
       (CustomBuild target) ->
         C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsof
       t.CppCommon.targets(237,5): warning MSB8065: Custom build for item "C:\OpenRV\_build\CMakeFi
       les\d2708addcadbb8629f109d12d3d452c4\libcrypto-1_1-x64.dll.rule" succeeded, but specified ou
       tput "c:\openrv\_build\stage\app\lib\libcrypto-1_1-x64.dll" has not been created. This may c
       ause incremental build to work incorrectly. [C:\OpenRV\_build\cmake\dependencies\RV_DEPS_OPE
       NSSL-stage-target.vcxproj]
         C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Microsoft\VC\v170\Microsof
       t.CppCommon.targets(237,5): warning MSB8065: Custom build for item "C:\OpenRV\_build\CMakeFi
       les\d2708addcadbb8629f109d12d3d452c4\libcrypto-1_1-x64.dll.rule" succeeded, but specified ou
       tput "c:\openrv\_build\stage\app\lib\libssl-1_1-x64.dll" has not been created. This may caus
       e incremental build to work incorrectly. [C:\OpenRV\_build\cmake\dependencies\RV_DEPS_OPENSS
       L-stage-target.vcxproj]

Describe the reason for the change.

To not get this warning anymore.

Describe what you have tested and on which operating system.

On Windows, it doesn't show the warning anymore.

Add a list of changes, and note any that might need special attention during the review.

NA

If possible, provide screenshots.

NA

herronelou avatar Apr 01 '25 00:04 herronelou

@herronelou Could you fix the issue with the DCO?

cedrik-fuoco-adsk avatar Apr 25 '25 13:04 cedrik-fuoco-adsk

Ahh I was just about to PR this. Thanks for the submission. Hopefully this gets merged soon.

wywarren avatar May 03 '25 08:05 wywarren

DCO fixed (and code rebased on main)

herronelou avatar May 03 '25 22:05 herronelou