OpenRV icon indicating copy to clipboard operation
OpenRV copied to clipboard

Add Noto font so that RV can render Mandarin characters

Open chxmberland opened this issue 1 year ago • 3 comments

Linked issues

N/A

Summarize your change.

A new font has been added to RV's UI with the capability to render Latin and Mandarin characters.

Describe the reason for the change.

RV uses hardcoded fonts for it's the UI. The existing fonts did not have the capability to render mandarin characters, so a new font (Google Noto) needed to be added to give RV the capability of rendering mandarin glyphs.

Describe what you have tested and on which operating system.

macOS Sonoma 14.5.

Add a list of changes, and note any that might need special attention during the review.

A change that should be ignored is in noto.cpp, which contains a byte array of a ttf file. This is how RV consumes fonts.

If possible, provide screenshots.

Before:

Snipaste_2024-07-11_11-20-11

After:

image

chxmberland avatar Jul 18 '24 19:07 chxmberland

This may be a non related question, but does this solve the 'only english' supported annotation text tool issue?

kohyuk91 avatar Jul 19 '24 09:07 kohyuk91

This may be a non related question, but does this solve the 'only english' supported annotation text tool issue?

It doesn't look like it. The annotation tool does not yet detect non-English keyboard options.

chxmberland avatar Jul 19 '24 14:07 chxmberland

This may be a non related question, but does this solve the 'only english' supported annotation text tool issue?

It doesn't look like it. The annotation tool does not yet detect non-English keyboard options.

Thank you for your reply! Really wish that could be fixed too.

kohyuk91 avatar Jul 20 '24 07:07 kohyuk91