onion skin management in annotate tool

[mamouth13]

OnionSkin management in annotation

Modifications

Added 5 properties into the PaintIPNode node:

• onionShow : enabled/disabled the drawing of onionSkin (default is false).
• onionBeforeFrame: the number of frames BEFORE a stroke on which the onionSkins will be drawn (default is 5).
• onionAfterFrame: the number of frames AFTER a stroke on which the onionSkins will be drawn (default is 5).
• onionBeforeColor: the color used to draw onionSkin BEFORE (default is red).
• onionAfterColor: the color used to draw onionSkin AFTER (default is green).

Paint::PolyLine and Paint::Text now manage those new properties and draw onionSkin on previous / next frames with the appropriate fading out colors.

Modified the annotate rv-package:

• Modified drawpane.ui to add the appropriate Ui to manage the above new properties.
• Modified annotate_mode.mu to properly handle the colorChooser with those new Ui.

Tests

This has been tested on CentOS Linux 7.

Screenshot

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: mamouth13 / name: Thierry LAUTHELIER (4da8c5b9b843a7b2d97cb069bc0748b4ed5f68c4, 00976d4a2cd47b283ad8f0c542eb1ec46f63c020)

[bernie-laberge]

Bonjour @mamouth13 , We apologize for the delay in reviewing your pull requests due to the fact that some key reviewers were on vacation.

Thank you for this excellent contribution to the Open RV effort !

[mamouth13]

Hi Bernard You are welcome 😉 TL

Le mar. 16 juil. 2024, 15:38, Bernard Laberge @.***> a écrit :

Bonjour @mamouth13 https://github.com/mamouth13 , We apologize for the delay in reviewing your pull requests due to the fact that some key reviewers were on vacation.

Thank you for this excellent contribution to the Open RV effort !

— Reply to this email directly, view it on GitHub https://github.com/AcademySoftwareFoundation/OpenRV/pull/498#issuecomment-2230918943, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDAOIQ6AHYFARN4LYN4M6ATZMUO6HAVCNFSM6AAAAABJ2F4J72VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMZQHEYTQOJUGM . You are receiving this because you were mentioned.Message ID: @.***>

[pbergeron-adsk]

Salut @mamouth13 Thierry LAUTHELIER !

Just a quick note to let you know about what's going on with this PR, and why it hasn't been merged yet.

First, we're working on a design for something similar, so as to not have conflicting functionality, this wasn't merged in.

But we will still internally review this PR in conjunction with the other feature. To do this, and because it will get me a bit better flexibility to experiment with things, I've taken over this PR and these changes in my own fork because it's old and there were non-trivial merge conflicts to fix with the latest main. Also, in the future, it would be helpful if in your fork you committed new code in a new branch, not main directly :)

In any case, I will close this PR a the coming days, but your code will live through my other PR, at least for a while. It is located here: https://github.com/AcademySoftwareFoundation/OpenRV/pull/774

@eloisebrosseau @bernie-laberge

[pbergeron-adsk]

closing pr since another pr replaces it.

[mamouth13]

Thank you for the update. Hope this will help.