cuebot: Make frames and layers readonly after job is done

[akim-ruslanov]

Link the Issue(s) this Pull Request is related to. Retrying a frame in a finished job will cause the frame to go back into the waiting state and the job will return to the cue. This even bypasses checks on duplicate job names, so two jobs with the same name can be running at the same time. Hence, it should be disallowed to retry frames on finished jobs, and the finished jobs should be read only.

Summarize your change. Endpoints that edit layers or frames now check whether or not the job is finished. If it is finished, then an error is returned. This will make sure the job is readonly from cuebot side.

[DiegoTavares]

This issue has been discussed on the TSC:

To avoid impacting other pipelines where it would make sense to retry frames on finished jobs, this feature should be configurable by a flag on the config file.

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: akim-ruslanov / name: Akim Ruslanov (ae1f66024b24d7db3c144338a3763022d4508a38, d956bdb47712f84d852e4386bfd067e7105c49d5)

[akim-ruslanov]

This issue has been discussed on the TSC:

To avoid impacting other pipelines where it would make sense to retry frames on finished jobs, this feature should be configurable by a flag on the config file.

I added a flag to toggle this feature. The default behavior will be allowing the frames/layers be editable even if the flag is not defined. I am hoping that this would make sure it won't break any pipelines. To toggle this feature on, you will have to explicitly add flags for both layer and frame in the prop file.