MaterialX icon indicating copy to clipboard operation
MaterialX copied to clipboard

Add MaterialX Python to PyPi

Open jstone-lucasfilm opened this issue 4 years ago • 1 comments

Add the MaterialX Python library to the PyPi registry, making it available from the command line via "pip install" on Windows, Linux, and MacOS. Some starting references may be found below:

https://pypi.org/ https://github.com/pybind/python_example

jstone-lucasfilm avatar Jan 25 '21 23:01 jstone-lucasfilm

And Conda, while you're at it :)

meshula avatar Jan 25 '21 23:01 meshula

Here is a small list of ASWF examples:

  • https://github.com/AcademySoftwareFoundation/OpenTimelineIO/blob/main/setup.py
  • https://github.com/AcademySoftwareFoundation/OpenColorIO/blob/main/setup.py
  • https://github.com/OpenAssetIO/OpenAssetIO/blob/main/setup.py

The general idea is to run the build from the setup.py. I'll be more than happy to help if needed.

Hey everyone, Can the project maintainers assign this issue to me so I can get the task done and open a PR resolving the same. Thank you.

TRohit20 avatar Mar 01 '23 17:03 TRohit20

That would be much appreciated, @TRohit20! Let's check with @kwokcb and @JeanChristopheMorinPerso before proceeding, since they have expressed interest in this feature as well, but otherwise I would have no reservations about assigning the issue to you.

jstone-lucasfilm avatar Mar 01 '23 20:03 jstone-lucasfilm

Awesome, Looking forward to work on it if it gets assigned

TRohit20 avatar Mar 02 '23 10:03 TRohit20

Thanks for offering to take this on, @TRohit20, and feel free to reach out to @JeanChristopheMorinPerso, @kwokcb, or me if you have questions!

jstone-lucasfilm avatar Mar 02 '23 22:03 jstone-lucasfilm

Sure thing, I will get started from tomorrow!

TRohit20 avatar Mar 03 '23 11:03 TRohit20

@TRohit20 Just checking in on this GitHub Issue, to see if you've had a chance to take an initial look. We've incorporated a couple of improvements to our Python package in preparation for MaterialX 1.38.7, and these could end up being helpful in integrating MaterialX with PyPi as well:

https://github.com/AcademySoftwareFoundation/MaterialX/pull/1237 https://github.com/AcademySoftwareFoundation/MaterialX/pull/1313

jstone-lucasfilm avatar Apr 08 '23 20:04 jstone-lucasfilm

I created a PR: https://github.com/AcademySoftwareFoundation/MaterialX/pull/1317