Imath icon indicating copy to clipboard operation
Imath copied to clipboard

Update PyImathEuler.cpp

Open faizhaque opened this issue 1 year ago • 3 comments

For issue #427 Make some changes by converting the Boost.python bindings for the Imath::Euler class to pybind11. Replaced boost.python headers and other changes. Followed the example template so still error testing. Wrappings should be somewhat functional

faizhaque avatar Oct 03 '24 23:10 faizhaque

Also a bit of a disclaimer, this is my first time using pybind11 bindings and my first time experience with this repo. Would appreciate the support!

faizhaque avatar Oct 03 '24 23:10 faizhaque

@faizhaque, we'd like to accept this contribution, but would prefer to see the changes noted above, moving the code into the pybind11 subdirectory. Would you be able to address that soon? If you have any questions, we're happy to help. Thanks!

cary-ilm avatar Oct 10 '24 18:10 cary-ilm

Following up on this again, @faizhaque, would you be able to finish off the requested changes? Thanks!

cary-ilm avatar Nov 03 '24 21:11 cary-ilm

Hello, Sorry for the late changes, I created a pull request to move the file into the correct location. Sorry about the delay

Faizan Haque Computer Science Major @ UF Phone Number: 813-323-1272

On Sun, Nov 3, 2024 at 4:19 PM Cary Phillips @.***> wrote:

Following up on this again, @faizhaque https://github.com/faizhaque, would you be able to finish off the requested changes? Thanks!

— Reply to this email directly, view it on GitHub https://github.com/AcademySoftwareFoundation/Imath/pull/441#issuecomment-2453580496, or unsubscribe https://github.com/notifications/unsubscribe-auth/BDQZKYSHCJYKHIYLHZYMV7TZ62AO7AVCNFSM6AAAAABPKZRCISVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJTGU4DANBZGY . You are receiving this because you were mentioned.Message ID: @.***>

faizhaque avatar Nov 03 '24 21:11 faizhaque

Closing in favor of #454.

cary-ilm avatar Dec 16 '24 02:12 cary-ilm