stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Bug]: "Override settings" is confusing and I'd prefer it to be disabled

Open space-nuko opened this issue 2 years ago • 9 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues and checked the recent builds/commits

What happened?

I find myself frustrated by the Override settings feature more often than not. Often what happens is:

  1. I load an infotext from PNG Info. I look at the model name and it matches something in my model list, figure "it will switch over"
  2. But it doesn't because they used a pruned version of the model which is missing from my list, meaning the hash was different, so I switch the model manually with the dropdown at the top
  3. But when I generate I forget that PNG Info also sets an override on the model hash setting, so my manual change is ignored, it fails to find the model with that exact hash, and then loads a completely random model that I didn't want

I'd rather just have the "Override settings" feature disabled if it's this confusing to use, I always end up deleting all the settings anyway. But the only setting that's configurable is sending the model hash, all other settings will always have overrides set

Why not instead have a checkbox list in the PNG Info tab that allows you to select which parameters detected in the infotext you'd want to send over? Would help reduce confusion on what gets overridden/changed

Steps to reproduce the problem

(Use PNG Info like above)

What should have happened?

N/A

Commit where the problem happens

a2d635ad135241a0a40f67f7e1638c9c8a4ded04

What platforms do you use to access the UI ?

Windows

What browsers do you use to access the UI ?

Google Chrome

Command Line Arguments

=--deepdanbooru --xformers --opt-split-attention --listen --enable-insecure-extension-access --gradio-inpaint-tool color-sketch --allow-code --no-half-vae

List of extensions

N/A

Console logs

N/A

Additional information

No response

space-nuko avatar Feb 23 '23 02:02 space-nuko

metoo I have confirmed this phenomenon with 0cc0ee1 and 226bc0

koh-taka avatar Feb 24 '23 00:02 koh-taka

I also think the current implementation of 'Override settings' is... not ideal. I like the concept and potential for them, but it could use some enhancements.

My thoughts:

  • You can't see the overrides where they are at the bottom without a very tall screen, unless you compulsively scroll down and look every, single, time that you import image info. Very easy to forget to do so. **At minimum, they should be displayed somewhere at the top, such as above or below the prompt box.
  • The overrides would be easier to notice (even at the top) if they had a more contrasting color, like red or yellow background.
  • Would be nice to have an overall checkbox next to the group to disable/enable using all populated overrides, without deleting them.
  • Global setting to enable or disable by default (pairs with previous idea)
  • A second global setting to hide them completely (if disabled by default). This would effectively disable overrides if the user doesn't want them.
  • I also like the OP's suggestion of some way to select which values to transfer over from PNG Info tab (but I'm not sure how complex that would be to implement).

Bug I currently see: If I import image data with a model hash that I'm already using (still loaded), it adds the same model hash to the overrides needlessly. Conversely, if I'm using the same clip skip value (for example) as the image data, it will ignore it and properly leave it out of the overrides.

  • This means if I'm loading image data from earlier in a session where I had only used the same model, and then switch to a new model to see the difference, I have to remember to go delete the override that shouldn't have been populated in the first place. Naturally I always forget until after I waste time generating. Also wastes time swapping models around when I didn't want to anyway.
  • This is separate from the OP's problem using same-named model that has different hash.

Here's a screenshot of loading image data that had the same model hash as what was already loaded: screenshot 1

EfourC avatar Feb 24 '23 03:02 EfourC

Extra thoughts:

  • Would be very nice to put the model name that goes with the hash, if found, in the override text. Currently, I have to squint and hunt through the entire list trying to find the matching hash... which might not even exist.
  • If no matching hash is found, indicate that somehow in the override text.

EfourC avatar Feb 24 '23 03:02 EfourC

A way to shut off override system in settings would be ideal. Gaining back how it worked, were a png could be dragged in and everything including ckpt/safetensor was loaded, if "When reading generation para..." was off. Sparing everyone the many described shenanigans that don't help the workflow. Why this was even put in and left half buggy, guess someone thought they had the sole workflow insight and moved on.

f-rank avatar Feb 24 '23 19:02 f-rank

A way to shut off override system in settings would be ideal. Gaining back how it worked, were a png could be dragged in and everything including ckpt/safetensor was loaded, if "When reading generation para..." was off. Sparing everyone the many described shenanigans that don't help the workflow. Why this was even put in and left half buggy, guess someone thought they had the sole workflow insight and moved on.

Yeah I agree with that too.. Regardless of any of my comments, a way to disable it for the original workflow is needed, particularly since it's currently half-baked.

EfourC avatar Feb 24 '23 20:02 EfourC

A way to shut off override system in settings would be ideal. Gaining back how it worked, were a png could be dragged in and everything including ckpt/safetensor was loaded, if "When reading generation para..." was off. Sparing everyone the many described shenanigans that don't help the workflow. Why this was even put in and left half buggy, guess someone thought they had the sole workflow insight and moved on.

Absolutely agree with making the new method optional in a way that can make the old workflow available again. I too find the override settings clunky, confusing and frustrating.

Somasonic avatar Feb 25 '23 19:02 Somasonic

Can we get a fix please? It's a hidden pitfall, to a time consuming process. I want to disable it

mattehicks avatar Mar 02 '23 23:03 mattehicks

Coming back a week later... Is there a "hack" available? I'd like to at least disable this in my installation. Edit: change line 32 in /modules/generation_parameters_copypase.py self.override_settings_component = None

mattehicks avatar Mar 09 '23 21:03 mattehicks

check this out you can select which overrides to ignore when import along with a bunch of cool staff https://github.com/AUTOMATIC1111/stable-diffusion-webui/pull/7519

anapnoe avatar Mar 11 '23 13:03 anapnoe

this function is straight up annoying thankfully I can remove it from code

AG-w avatar Sep 12 '23 18:09 AG-w

And I'm wondering how "override settings" affects if another model or clipskip does not match in the list A1111. Or are these values just for my information?

nyukers avatar Sep 21 '23 14:09 nyukers

I have stumbled into an issue where, if I dont have an override setting to my prompt, the image wont generate. It will tell me the following error: "TypeError: 'NoneType' object is not iterable", which is really frustrating. Is there a way to fix this, where I dont have to keep an "override setting" to generate my images?

Daniel-Ove avatar Jul 09 '24 23:07 Daniel-Ove

Adding my +1 to this, it has frequently cost me a lot of time when I keep changing models to see what will give me what I'm looking for and none of them seem to work well... because it wasn't actually changing. For every other setting, when I load info from PNG, it just applies the setting directly and if I change the setting it is happy to oblige. This "feature" not only resists a direct, active choice and interaction I've made with the UI - outright insisting "nah you didn't really mean to do that" - it also sneaks its self in with the sliders that I'm probably not even looking at if my intent is just changing over to a different model.

DejitaruJin avatar Jul 10 '24 02:07 DejitaruJin

Every time I send to txt2img from PNG info, VAE settings are overwritten. If I generate it as it is, it seems that VAE cache is not used, and RAM consumption increases.

Hackgets avatar Aug 02 '24 02:08 Hackgets