stable-diffusion-webui icon indicating copy to clipboard operation
stable-diffusion-webui copied to clipboard

[Bug]: Inpainting inside mask does not work in firefox

Open garberino opened this issue 2 years ago • 11 comments

Is there an existing issue for this?

  • [X] I have searched the existing issues and checked the recent builds/commits

What happened?

I get these errors when inpainting in Firefox.

line 56, in f res = list(func(args, **kwargs)) line 37, in f res = func(args, **kwargs) line 169, in img2img processed = process_images(p) line 486, in process_images res = process_images_inner(p) line 579, in process_images_inner p.init(p.all_prompts, p.all_seeds, p.all_subseeds) line 949, in init mask = mask.crop(crop_region) line 1228, in crop raise ValueError(msg)

ValueError: Coordinate 'right' is less than 'left'

Win 10, Firefox. Brave works right

Steps to reproduce the problem

  1. Go to img2img, inpaint (paint over the image)
  2. Press only masked
  3. Gen stalls and get error messages. Error not reproducible in Brave. If entire picture is selected in masking options it spits out the same image.

What should have happened?

Properly inpaint.

Commit where the problem happens

commit: ea9bd9fc

What platforms do you use to access the UI ?

Windows

What browsers do you use to access the UI ?

Mozilla Firefox

Command Line Arguments

--autolaunch --xformers

List of extensions

no

Console logs

line 56, in f    res = list(func(args, **kwargs))
 line 37, in f    res = func(args, **kwargs)
line 169, in img2img    processed = process_images(p)
 line 486, in process_images    res = process_images_inner(p)
 line 579, in process_images_inner    p.init(p.all_prompts, p.all_seeds, p.all_subseeds)
 line 949, in init    mask = mask.crop(crop_region)
line 1228, in crop    raise ValueError(msg)

ValueError: Coordinate 'right' is less than 'left'

Additional information

No response

garberino avatar Feb 14 '23 08:02 garberino

this is a bug likely with input resolution of the mask being off or drawing a mask in a weird way. there aren't any checks for checking x1 < x2 and y1< y2. flipping the coordinate to the smaller one will remove the error but probably result in other issues when scaling the mask bc it wont line up correctly anymore . it may be caused by the canvas dimensions in firefox or privacy focused browsers being different than expected bc sometimes certain canvas functionality is disabled to prevent browser fingerprinting . you should try with an uploaded 512by512 mask that matches your dimensions and see if that fixes your issue.

rakataprime avatar Feb 15 '23 08:02 rakataprime

Disable duckduckgo privacy essentials beforehand

G-force78 avatar Feb 17 '23 08:02 G-force78

I never had those essentials. It's broken in Chrome and Edge. I tried incognito mode, it's broken there as well. Please fix it. For me it happens when I try to inpaint only masked for the second time, happens consistently, Happened in 3 different browser configs. Does not recover when it breaks - most annoying.

VictorZakharov avatar Feb 18 '23 21:02 VictorZakharov

Today I observed the reported error behaviour in Firefox 110 (x64) on every attempt to inpaint within mask, not just the second or subsequent one. This is with both a recent pull [7202213] and when reverting to an older one [226d840] which had worked previously with whatever version of Firefox was current on ~9-Feb-2023~ 12-Feb-2023 and the same set of extensions and restrictions.

The behaviour of whole-image inpainting was consistent with no mask information having been transmitted - either the output was equal to the input, or the whole image changed depending whether "inpaint masked" or "inpaint not masked" was selected.

Having a null mask something like (0,0) to (-1,-1) would seem a potential source of the right less than left error condition, and the inpainting failure at whole image level.

My current workround is to use Edge (version 110.0.1587.50)

Edited to fix date of last-known-good Firefox.

SteveGilham avatar Feb 19 '23 20:02 SteveGilham

That was yesterday; today, the same (older commit) set-up that didn't work on Firefox yesterday, but did on Edge started on Edge and appears to ignore the mask and just do img2img; transferring back to Firefox, the "inpaint masked" option appears to function as "inpaint no masked" and vice-versa; as this was the same subject image and near-identical mask, I've not yet tested whether the mask is one from Edge that's "stuck" by not being overwritten from Firefox; nor have I updated to a current commit.

SteveGilham avatar Feb 20 '23 16:02 SteveGilham

I have the same exact behaviour, Steve. Resorted to using Brave for the time being.

garberino avatar Feb 24 '23 11:02 garberino

Same issue. Chrome, Brave, Firefox, and Safari do not work for me. No matter what the settings are at: Mask mode: Inpaint masked/ Inpaint not masked Inpaint area: Whole picture/ Only masked I always get an entirely new image based on the prompt. I've used inpainting many times in the past.

johnnybpena1989 avatar Feb 25 '23 17:02 johnnybpena1989

Haven't used inpainting in a couple of weeks, but tried it today and was also getting fresh images no matter the settings/browser. The only thing that I know I've done between then and now is having installed controlnet. Not seeing any errors. Just fresh generations with no reference to the image. In fact, none of the img2img features are working.

ourladyofagi avatar Feb 26 '23 04:02 ourladyofagi

I typed that out then I had an "AHA" moment. During the controlnet setup, it is suggested that one toggle the "Skip img2img processing when using img2img initial image" off for batch processing, which I had done. This was incapacitating all of the img2img stuff. If you're having problems and have recently installed controlnet, try this.

ourladyofagi avatar Feb 26 '23 04:02 ourladyofagi

I typed that out then I had an "AHA" moment. During the controlnet setup, it is suggested that one toggle the "Skip img2img processing when using img2img initial image" off for batch processing, which I had done. This was incapacitating all of the img2img stuff. If you're having problems and have recently installed controlnet, try this.

I kinda figured it had something to do with ControlNet. Only thing though, I never came across any install settings when I installed. I just used the extensions tab and it did everything.

johnnybpena1989 avatar Feb 26 '23 05:02 johnnybpena1989

@ourladyofagi I'm not doing batch processing, but I still have this issue.

VictorZakharov avatar Feb 26 '23 12:02 VictorZakharov

Encountered this bug. Same error message, right is less than left Firefox - error Brave - error Edge - works

Arctomachine avatar Mar 29 '23 02:03 Arctomachine

Turning down "Only masked padding, pixels" Wayyyyyyyy low will stop this problem. Also, drawing more/less/different shapes of the mask could fix it as well in my experience.

Grandvichy avatar Jul 07 '23 09:07 Grandvichy

I'm using Firefox and cannot reproduce this. It's likely some privacy setting as others have mentioned in this thread since inpainting uses a canvas object.

catboxanon avatar Aug 15 '23 18:08 catboxanon