DAPLink icon indicating copy to clipboard operation
DAPLink copied to clipboard

Add support for Cypress devices

Open MarianSavchuk opened this issue 6 years ago • 16 comments

MarianSavchuk avatar Mar 08 '19 15:03 MarianSavchuk

@p2k000 Can you please rebase onto master? You might want to squash down to 1 or 2 commits. You will need to force push.

The recent changes to add the K26F HIC are showing up in this PR, which greatly increases the number of changed files. This is also why projects.yaml is showing as having conflicts.

Thanks!

Btw, we prefer to not have merges to/from master or other branches in pull requests. This keeps the git history much cleaner.

flit avatar Mar 13 '19 15:03 flit

@p2k000 Would you mind rebasing and squashing? We need to remove the merge commits to have a clean commit history. You will need to force push after you rebase. Thanks!

flit avatar Mar 20 '19 18:03 flit

Fyi, #612 has been merged now. You can now rebase on top of master and remove the target-specific changes to common code in this PR.

flit avatar Mar 22 '19 17:03 flit

Fyi, #612 has been merged now. You can now rebase on top of master and remove the target-specific changes to common code in this PR.

Please rebase again. Shall we proceed with this PR? what is the status here after the last review

0xc0170 avatar Sep 06 '19 13:09 0xc0170

@0xc0170, I will be ready to publish all modified sources on WW1940. At the moment, almost all comments are resolved.

MarianSavchuk avatar Sep 10 '19 14:09 MarianSavchuk

@MarianSavchuk I merged one of your PRs, reviewing others. This will need a rebase (and its ready for final review?). let me know

0xc0170 avatar Mar 26 '20 07:03 0xc0170

/morph test

0xc0170 avatar Mar 30 '20 11:03 0xc0170

/morph test

0xc0170 avatar Apr 07 '20 10:04 0xc0170

/morph test

0xc0170 avatar Apr 07 '20 10:04 0xc0170

/morph test

0xc0170 avatar Apr 08 '20 10:04 0xc0170

/morph test

0xc0170 avatar Apr 08 '20 10:04 0xc0170

11:50:39 [Error] CyBootAsmRv.s@49,22: A1516E: Bad symbol 'CYDEV_INSTRUCT_CACHE_ENABLED', not defined or external
11:50:40 [ERROR] ".\\source\\hic_hal\\cypress\\psoc5lp\\armcc\\CyBootAsmRv.s", line 29: Error: A1023E: File "cyfitterrv.inc" could not be opened: No such file or directory
11:50:40    29 00000000     GET cyfitterrv.inc
11:50:40 ".\\source\\hic_hal\\cypress\\psoc5lp\\armcc\\CyBootAsmRv.s", line 49 (column 8): Error: A1516E: Bad symbol 'CYDEV_INSTRUCT_CACHE_ENABLED', not defined or external
11:50:40    49 00000000     IF CYDEV_INSTRUCT_CACHE_ENABLED == 1
11:50:40                       ^
11:50:40 2 Errors, 0 Warnings

Build errors reported, please review

0xc0170 avatar Apr 08 '20 10:04 0xc0170

will this happen? @MarianSavchuk please consider adding psoc4 as well

raveslave avatar Feb 18 '21 21:02 raveslave

@flit, @0xc0170 Could you please consider this PR again. All your previous comments have been addressed.

MarianSavchuk avatar Oct 01 '21 11:10 MarianSavchuk

@flit @0xc0170 -- any chance for a re-review?

nimish avatar Apr 28 '22 19:04 nimish

Hi @nimish @MarianSavchuk, I failed to notice this PR was still active. Could you rebase and add the startup for GCC ARM?

mbrossard avatar Jan 04 '23 03:01 mbrossard