AR.js icon indicating copy to clipboard operation
AR.js copied to clipboard

Published 20 hours ago • verified publisher icon AR-js-org

ios fix (#466) applied manually to existing DeviceOrientationControls

Open nickw1 opened this issue 8 months ago • 3 comments

⚠️ All PRs have to be done versus 'dev' branch, so be aware of that, or we'll close your issue ⚠️

What kind of change does this PR introduce?

Fixes iOS device orientation issues for location-based AR.

Can it be referenced to an Issue? If so what is the issue # ? 466

How can we test it?

Test the location-based examples within the A-Frame examples directory, particularly basic-js.

Summary

Fix was made primarily by @json91-dev. I applied it to the existing repo. Please see #466 for more details.

Does this PR introduce a breaking change? No

Please TEST your PR before proposing it. Specify here what device you have used for tests, version of OS and version of Browser Personally tested in Chrome on Android 10. Others have tested on iOS. Please see #466

Other information @kalwalt can you check this? Thanks.

nickw1 avatar Mar 14 '25 12:03 nickw1

Hi @nickw1 i will check and test the code when i will have a bit of time. 🙂

kalwalt avatar Mar 14 '25 16:03 kalwalt

Hi @kalwalt many thanks!

nickw1 avatar Mar 14 '25 19:03 nickw1

Superseded by #661 (which is verified as working on Android and iOS). @kalwalt shall I close this or do you want to keep it open in order to test this fix in isolation?

nickw1 avatar Mar 25 '25 16:03 nickw1