ElegantRL icon indicating copy to clipboard operation
ElegantRL copied to clipboard

traj_list is wrong in demo_FinRL_ElegantRL_China_A_shares

Open niceban opened this issue 2 years ago • 2 comments
trafficstars

traj_list = [map(list, zip(*traj_list))] should be changed into traj_list = list(zip(*traj_list)) and cur_items = [map(list, zip(*traj_list))] should be changed into cur_items = list(zip(*traj_list))

niceban avatar Feb 28 '23 02:02 niceban

We have fixed these bugs for the main algorithms (DQN, DoubleDQN, DualingDQN, D3QN, DDPG, TD3, SAC and PPO), the algorithm related to Hterm has not been updated (DDPG_H, PPO_H), thank you for the reminder, I will take the time to change these codes.

We had update these code for the main algorithms just like:

https://github.com/AI4Finance-Foundation/ElegantRL/blob/68bf0ea4ef3fb461026ece8897deabb92aeead32/elegantrl/agents/AgentBase.py#L84-L94

Yonv1943 avatar Mar 01 '23 11:03 Yonv1943

At the moment, I seem to have encountered the same problem with #288 niceban

2023-03-03 145756

LunbiWa avatar Mar 03 '23 07:03 LunbiWa