ElegantRL icon indicating copy to clipboard operation
ElegantRL copied to clipboard

Suggestion: AgentXXX.py if_act_target if_cri_target

Open Yonv1943 opened this issue 3 years ago • 2 comments

There are bug in if_act_target and if_cri_target in AgentBase.py

class AgentXXX.__init__() should set args.if_cri_target = getattr(self, "if_cri_target", True) (or False) in default.

Takes AgentDQN as an example, the following code should be changed.

https://github.com/AI4Finance-Foundation/ElegantRL/blob/3ded1cef5d9c9100422935141b07d3ec5301db4b/elegantrl/agents/AgentDQN.py#L21-L26

Change to fhe following code (as ElegantRL HelloWorld version do): https://github.com/AI4Finance-Foundation/ElegantRL/blob/3ded1cef5d9c9100422935141b07d3ec5301db4b/elegantrl_helloworld/agent.py#L62-L69

Yonv1943 avatar Apr 22 '22 10:04 Yonv1943

1 If the default value is true, how to set it as false?

2 if getattr is to set value for an attr, it should be setattr. getattr only gets values instead of changing values.

zhumingpassional avatar Apr 23 '22 02:04 zhumingpassional

Isn't it self.if_act_target?

uzhao avatar Sep 19 '22 06:09 uzhao