sheepit-docker icon indicating copy to clipboard operation
sheepit-docker copied to clipboard

Start script does not handle signals

Open AGSPhoenix opened this issue 9 years ago • 3 comments

With the new signal handling in the client, being able to send a ctrl-c via docker kill would be a nice feature.

AGSPhoenix avatar Apr 10 '16 21:04 AGSPhoenix

docker stop {dockername} works fine for me... if you still want a ctrl-c, i can look into it, shouldn't be hard

CryoRig avatar Oct 20 '17 20:10 CryoRig

My desire with this was to have the client's graceful shutdown capability usable from docker commands. Given that docker stop defaults to a 10 second delay before killing the container though, and an ongoing render could take upwards of half an hour to complete, that may simply not be feasible. If you want to take a look, let me know how it goes.

AGSPhoenix avatar Oct 22 '17 02:10 AGSPhoenix

Since this issue was created docker runtime added support for the --init option, If enabled it just interjects the tini init system, which handles signal handling and process reaping automatically (the latter won't be an issue in sheepit's case most likely) and doesn't interfere with anything else. Though it would most likely kill the render process immediately.

DaCoolX avatar Feb 15 '19 09:02 DaCoolX