AElf icon indicating copy to clipboard operation
AElf copied to clipboard

Will release a new version to switch back the Web API response json naming policy to upper camel case.

Open EanCuznaivy opened this issue 3 years ago • 2 comments

Is your feature request related to a problem? Please describe. Yes. In origin v1.2.0 version, the UpperCamelCaseNamingStrategy class of AElf.WebApp.Web doesn't take effect, and we release that version before a full test process is finished. So if anyone uses v1.2.0 directly, all the aelf SDKs won't work normally. That is a mistake.

Describe the solution you'd like As there's already a fix in the dev branch (because we want a correct docker image quickly), I use a UpperCamelCaseNamingPolicy to replace the old UpperCamelCaseNamingStrategy, then the naming policy takes effect as in previous versions. But maybe there's another solution which is more elegant. I'll try to figure it out.

Describe alternatives you've considered It's a hotfix. Nothing more.

Additional context Won't be so long.

TODO List:

  • [x] Fork a feature/v1.2.0-webapifix branch from master branch (because we want to publish a new NuGet package for this fix)
  • [x] Commit fix code to feature/v1.2.0-webapifix
  • [x] PR feature/v1.2.0-webapifix to dev branch: #3321
  • [x] Merge feature/v1.2.0-webapifix to dev then master
  • [ ] Tag v1.2.1

EanCuznaivy avatar Jul 05 '22 09:07 EanCuznaivy

we have the same problem.

blocknodehub avatar Jul 27 '22 05:07 blocknodehub

we have the same problem.

With aelf or .net?

EanCuznaivy avatar Aug 01 '22 07:08 EanCuznaivy