AElf icon indicating copy to clipboard operation
AElf copied to clipboard

[WIP] PoW mechanism implementations.

Open EanCuznaivy opened this issue 5 years ago • 10 comments
trafficstars

For reviewing.

EanCuznaivy avatar Jul 11 '20 16:07 EanCuznaivy

Calculated based on blockchain start time.

https://github.com/AElfProject/AElf/blob/7e8e8065e93601e476935357bab72603428e9e94/contract/AElf.Contracts.Consensus.AEPoW/AEPoWContract_Coinbase.cs#L28-L33


This comment was generated by todo based on a TODO comment in 7e8e8065e93601e476935357bab72603428e9e94 in #2935. cc @AElfProject.

todo[bot] avatar Jul 11 '20 16:07 todo[bot]

Pull request analysis by VIZIPI

Below you will find who is the most qualified team member to review your code. This analysis includes his/her work on the code included in this Pull request, in addition to their experience in code affected by these changes ( partly found within the list of potential missing files below )   Feedback always welcome

Reviewers with knowledge related to these changes

Match % Person Commit Count Common Files
37.97 % ZhangXin 148 30
37.97 % weili 39 30
36.71 % jason-hoopox 87 29
35.44 % Peng Rong 89 28
30.38 % swk 214 24
26.58 % xiangxingxing 109 21

Potential missing files from this Pull request

No commonly committed files found with a 40% threashold


Committed file ranks

  • 57.19%[contract/AElf.Contracts.Consensus.AEPoW/AEPoWContract.cs]
  • 88.24%[...src/AElf.Kernel.SmartContract.Shared/ISmartContractBridge]
  • 20.80%[...test/AElf.Contracts.Association.Tests/UnitTestTokenContra]
  • 20.80%[...test/AElf.Contracts.MultiToken.Tests/UnitTestTokenContrac]
  • 50.73%[protobuf/aepow_contract.proto]
  • 99.13%[...src/AElf.Kernel.SmartContractExecution/Application/BlockE]
  • 40.70%[...test/AElf.Contracts.MultiTokenCrossChainTransfer.Tests/Mu]
  • 0.00%[...src/AElf.Kernel.Consensus.Core/Application/DefaultConsens]
  • 82.54%[src/AElf.ContractTestBase/MainChainContractTestModule.cs]
  • 99.86%[test/AElf.Contracts.TestBase/ContractTester.cs]
  • vizipi[bot] avatar Jul 11 '20 16:07 vizipi[bot]

    Codecov Report

    Merging #2935 into dev will decrease coverage by 0.10%. The diff coverage is 26.82%.

    Impacted file tree graph

    @@            Coverage Diff             @@
    ##              dev    #2935      +/-   ##
    ==========================================
    - Coverage   73.61%   73.50%   -0.11%     
    ==========================================
      Files         714      719       +5     
      Lines       27439    27492      +53     
      Branches     2172     2171       -1     
    ==========================================
    + Hits        20199    20209      +10     
    - Misses       6930     6973      +43     
      Partials      310      310              
    
    Impacted Files Coverage Δ
    ...icSystem/EconomicContractInitializationProvider.cs 0.00% <0.00%> (ø)
    ...ntSystem/ElectionContractInitializationProvider.cs 0.00% <0.00%> (ø)
    ...sus.AEDPoS/AEDPoSContractInitializationProvider.cs 0.00% <0.00%> (ø)
    src/AElf.Kernel.Consensus.AEDPoS/AEDPoSOptions.cs 100.00% <ø> (ø)
    .../DefaultConsensusContractInitializationProvider.cs 0.00% <0.00%> (ø)
    ...lication/IBroadcastPrivilegedPubkeyListProvider.cs 0.00% <0.00%> (ø)
    ...Core/Application/IConsensusReaderContextService.cs 100.00% <ø> (ø)
    ...us.Core/Application/ITriggerInformationProvider.cs 0.00% <0.00%> (ø)
    src/AElf.Kernel.Consensus.Core/ConsensusOptions.cs 0.00% <0.00%> (ø)
    ...s.Core/Application/IConsensusExtraDataExtractor.cs 31.57% <31.57%> (ø)
    ... and 9 more

    codecov[bot] avatar Jul 11 '20 16:07 codecov[bot]

    Cache nonce in Kernel code.

    https://github.com/AElfProject/AElf/blob/d978ce3e60bd8d2b87389ee6beba87d58864d676/contract/AElf.Contracts.Consensus.AEPoW/AEPoWContract.cs#L33-L38


    This comment was generated by todo based on a TODO comment in d978ce3e60bd8d2b87389ee6beba87d58864d676 in #2935. cc @AElfProject.

    todo[bot] avatar Jul 12 '20 21:07 todo[bot]

    Need to fix.

    https://github.com/AElfProject/AElf/blob/c0a2e7f484a35341073f98007a802e8623808cfb/contract/AElf.Contracts.Consensus.AEPoW/AEPoWContract.cs#L62-L67


    This comment was generated by todo based on a TODO comment in c0a2e7f484a35341073f98007a802e8623808cfb in #2935. cc @AElfProject.

    todo[bot] avatar Jul 14 '20 14:07 todo[bot]

    Comment because ELF not initialized.

    https://github.com/AElfProject/AElf/blob/c0a2e7f484a35341073f98007a802e8623808cfb/contract/AElf.Contracts.Consensus.AEPoW/AEPoWContract_Coinbase.cs#L35-L40


    This comment was generated by todo based on a TODO comment in c0a2e7f484a35341073f98007a802e8623808cfb in #2935. cc @AElfProject.

    todo[bot] avatar Jul 14 '20 14:07 todo[bot]

    ELF not initialized in PoW Chain.

    https://github.com/AElfProject/AElf/blob/ab91748ef1b9f0a95b363131f100d8ac4e06fb62/contract/AElf.Contracts.Consensus.AEPoW/AEPoWContract_Coinbase.cs#L37-L42


    This comment was generated by todo based on a TODO comment in ab91748ef1b9f0a95b363131f100d8ac4e06fb62 in #2935. cc @AElfProject.

    todo[bot] avatar Jul 15 '20 02:07 todo[bot]

    Make sure there's only one CoinBase tx in one block.

    https://github.com/AElfProject/AElf/blob/26f82f21d3387d61126d26637b134fb104d8636a/contract/AElf.Contracts.Consensus.AEPoW/AEPoWContract.cs#L33-L38


    This comment was generated by todo based on a TODO comment in 26f82f21d3387d61126d26637b134fb104d8636a in #2935. cc @AElfProject.

    todo[bot] avatar Aug 14 '20 14:08 todo[bot]

    Split.

    https://github.com/AElfProject/AElf/blob/26f82f21d3387d61126d26637b134fb104d8636a/src/AElf.Kernel.Consensus.Core/Application/DefaultConsensusContractInitializationProvider.cs#L8-L13


    This comment was generated by todo based on a TODO comment in 26f82f21d3387d61126d26637b134fb104d8636a in #2935. cc @AElfProject.

    todo[bot] avatar Aug 14 '20 14:08 todo[bot]

    Use a new branch to impl this.

    https://github.com/AElfProject/AElf/blob/26f82f21d3387d61126d26637b134fb104d8636a/src/AElf.Kernel.Core/Blockchain/Infrastructure/ISwitchLongestChainThresholdProvider.cs#L3-L8


    This comment was generated by todo based on a TODO comment in 26f82f21d3387d61126d26637b134fb104d8636a in #2935. cc @AElfProject.

    todo[bot] avatar Aug 14 '20 14:08 todo[bot]