parcel-plugin-prerender icon indicating copy to clipboard operation
parcel-plugin-prerender copied to clipboard

feature: Allow to pass server configuration

Open playpauseandstop opened this issue 5 years ago • 2 comments

By default Renderer server run at first free port after 8000, this MR allows plugin to configure server port via prerender.serverConfig

playpauseandstop avatar Jan 26 '20 14:01 playpauseandstop

Hi @ABuffSeagull,

I'd like to notice, that I'm unable to successfully run test suite on master branch (as well as my fork), so I cannot verify that my change will run well. It should but in case you found out any issues with implementation, I'll glad to fix them.

playpauseandstop avatar Jan 26 '20 14:01 playpauseandstop

Yeah, the tests have always been super flaky, I need to see if I can harden them up. But thank you, I'll look into this when I get the chance

ABuffSeagull avatar Jan 27 '20 14:01 ABuffSeagull