serverless-dynamodb-local icon indicating copy to clipboard operation
serverless-dynamodb-local copied to clipboard

Fix npm published version number

Open azizur opened this issue 6 years ago • 8 comments
trafficstars

Actual Behaviour

If you run npm audit

$ npm audit

                       === npm audit security report ===

# Run  npm install --save-dev [email protected]  to resolve 1 vulnerability
SEMVER WARNING: Recommended action is a potentially breaking change
┌───────────────┬──────────────────────────────────────────────────────────────┐
│ Moderate      │ Prototype Pollution                                          │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Package       │ node.extend                                                  │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Dependency of │ serverless-dynamodb-local [dev]                              │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ Path          │ serverless-dynamodb-local > dynamodb-localhost > rmdir >     │
│               │ node.flow > node.extend                                      │
├───────────────┼──────────────────────────────────────────────────────────────┤
│ More info     │ https://npmjs.com/advisories/781                             │
└───────────────┴──────────────────────────────────────────────────────────────┘

It advises you to instal: npm install --save-dev [email protected]

Expected Behaviour

It should offer to install the verson 0.2.37 as that is the latest version of the package. This is because npm registry version has 1.0.0, 1.0.1 and 1.0.2 version published 3 years ago.

Screenshot 2019-04-07 at 08 47 02

Steps to reproduce it

run npm audit

Would you like to work on the issue?

May be, it require npm publish access to fix this issue.

Potential options:

  1. Depricate npm releases 1.0.0, 1.0.1 and 1.0.2.
  2. Release a new version 1.2.38

I know that option 2 is against how semver works. In this case publishing those 1.x version has lead to this issue. However this will set things on the right track for future releases. Essentially you are doing a fake release to realign semver releases.

azizur avatar Apr 07 '19 08:04 azizur

Addressing this issue will potentially fixes #213, #211 and #134.

azizur avatar Apr 07 '19 08:04 azizur

@AshanFernando Any update on this?

azizur avatar Apr 21 '19 09:04 azizur

This issue is effecting my team as well, any update on it's completion?

marty331 avatar Apr 30 '19 16:04 marty331

@rehrumesh Is anyone going to address this? We've been affected by this due to npm audit fix too.

I think going to 1.2.38 would make the most sense.

nealeu avatar Jul 08 '19 11:07 nealeu

I'd suggest version 1.2.39.

drc-gcoakley avatar Jul 19 '19 19:07 drc-gcoakley

Any update on this issue?

azizur avatar Nov 14 '19 08:11 azizur

Has any progress been made on this? I'm also running into this problem

jasiene avatar Feb 08 '23 18:02 jasiene

Same issue, is there any plans to address this? Please and thank you

abdrabah avatar Apr 04 '23 09:04 abdrabah