Niagara-Issues icon indicating copy to clipboard operation
Niagara-Issues copied to clipboard

Home button animation

Open oniony opened this issue 3 years ago • 17 comments

Since I received version 1.5.2, the animation when returning to the homescreen from an app is broken.

Previous behaviour: hitting the home button would slide my current app downwards, revealing the homescreen and the icons would gently slide down into place across a few frames.

Current behviour: hitting the home button slides the app downwards revealing the launcher with the icons in their final positions and then clones of the icons slide down on top of them.

However, if I go into the app selector by hitting the square icon then the correct animation (without duplicates) is shown. It's only when I switch into an app and return home do the duplicate icons animate into place.

I'm on a Nokia 8 running Android 9.

oniony avatar Dec 31 '21 19:12 oniony

https://youtu.be/KJXdhy0kj8Q

oniony avatar Dec 31 '21 19:12 oniony

I've just found that if I switch to a static wallpaper the problem goes away, so this appears to be an issue with live wallpapers. I'm using Forest.

oniony avatar Dec 31 '21 19:12 oniony

Actually it happens with static wallpapers too, just not as predictably. With the static wallpaper it may happen some few seconds after returning to the launcher.

oniony avatar Dec 31 '21 19:12 oniony

I've seen this occur myself a few times, I suspect it's a bug in one of the libraries we use. Usually a launcher restart fixes it again, and it should only be triggered by updating or rebooting the device.

Does it happen more regularly for you?

Maxr1998 avatar Jan 04 '22 14:01 Maxr1998

Me too, i face the same problem with live wallpaper, so i stopped using it, in static wallpaper i face the same sometimes, but i see the issue more when unlocking the phone, it's not smooth

Amorphous404 avatar Jan 04 '22 18:01 Amorphous404

I've seen this occur myself a few times, I suspect it's a bug in one of the libraries we use. Usually a launcher restart fixes it again, and it should only be triggered by updating or rebooting the device.

Does it happen more regularly for you?

Yes, it happens all the time. Immediately after restarting the launcher (without pressing anything more) and following phone restart. In fact the only time it doesn't happen is when I go into the app switcher but don't actually switch.

oniony avatar Jan 04 '22 18:01 oniony

I'm pretty sure it didn't happen before the update. If you have any APKs of older builds I'd be willing to install to confirm exact version.

oniony avatar Jan 04 '22 18:01 oniony

All APKs from older updates are attached to the releases of this repo.

Maxr1998 avatar Jan 04 '22 23:01 Maxr1998

OK, I've installed each version. The problem is evident with every 1.5.x version. When I went back to 1.4.2 the problem is completely gone. So it was introduced in 1.5.0.

oniony avatar Jan 04 '22 23:01 oniony

Actually 1.4.2 is so silky smooth I think I'm just going to stick with that for now.

oniony avatar Jan 04 '22 23:01 oniony

I'm having the same problem. It's almost as if there are two copies of the launcher stacked, one with the Niagara widget loaded and the other where it loads as it displays.

App version 1.5.2 Samsung Galaxy S21 FE Android 11

https://user-images.githubusercontent.com/8191823/148151787-51f55101-f7d2-497d-8c06-5d1296da53a3.mp4

mazikowski avatar Jan 05 '22 02:01 mazikowski

Both of the underlying issues were identified and fixed. Should be rolled out in the next release.

Maxr1998 avatar Feb 07 '22 22:02 Maxr1998

Awesome, thank you!

oniony avatar Feb 07 '22 22:02 oniony

The same issue but while unlocking the phone still exist on V.1.6.5. (Galaxy A33) Pressing home button, or changing apps from home screen seems fine.

hexboxlabs avatar Jun 04 '22 14:06 hexboxlabs

It indeed seems like this issue still pops up occasionally. I have seen at least one other report on a Samsung phone as well, and it once happened to me too. I can't say if the fix didn't work in the first place or if it is a regression. I'll have to investigate.

Maxr1998 avatar Jun 07 '22 08:06 Maxr1998

I've been experiencing this when unlocking the screen to Niagara, it happens with every single unlock.

Device: Samsung Galaxy S22 Ultra (Exynos), OneUI 4.1

NiphraDil avatar Jul 20 '22 14:07 NiphraDil

It seems like on my Galaxy A52 the behaviour is like this:

  • when I unlock the phone using the on-screen fingerprint scanner it has the slide down animation which is buggy and layers on top of an already static Niagara UI
  • when I unlock using the pattern (I assume it's the same with pin) the unlock animation is like a zoom out into place and it's smooth

The bug might be related to a specific unlock animation or something, at least on Samsung

Oddward avatar Oct 09 '22 12:10 Oddward

@oniony do you still happen to face the issue with the home button?

Amorphous404 avatar Jan 21 '23 11:01 Amorphous404

It indeed seems like this issue still pops up occasionally. I have seen at least one other report on a Samsung phone as well, and it once happened to me too. I can't say if the fix didn't work in the first place or if it is a regression. I'll have to investigate.

The former issue did get fixed with the following updates on my older phone where i faced the issue with live wallpaper apps, but this seem to only get triggered via fingerprint unlock on some devices.

Not sure if i should merge this ticket https://github.com/8bitPit/Niagara-Issues/issues/2092 with this one 😅

Amorphous404 avatar Jan 21 '23 18:01 Amorphous404