PyQtDarkTheme icon indicating copy to clipboard operation
PyQtDarkTheme copied to clipboard

Add Python 3.12 Support, Drop Python 3.7

Open woopelderly opened this issue 2 years ago • 4 comments

fix #252

  • Update to support Python 3.12. To do this I also had to update pre-commit from 2.20 to 3.5 because of packaging methods that were removed in Python 3.12; specifically Python 3.12 removed the deprecated ImpImporter from pgkutil.

  • Drop Python 3.7 support because pre-commit 3.5 does not support Python 3.7.

  • The poetry.lock file was regenerated from within the Python 3.12 virtual environment.

woopelderly avatar Nov 16 '23 19:11 woopelderly

pre-commit.ci autofix

woopelderly avatar Nov 16 '23 19:11 woopelderly

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (96eb7e3) 97.12% compared to head (bbcf4d5) 96.92%.

:exclamation: Current head bbcf4d5 differs from pull request most recent head dcab630. Consider uploading reports for the commit dcab630 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   97.12%   96.92%   -0.21%     
==========================================
  Files          42       42              
  Lines        1498     1498              
==========================================
- Hits         1455     1452       -3     
- Misses         43       46       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 16 '23 19:11 codecov[bot]

Is this repository / project dead? Is there a replacement project?

kyleboyle avatar May 20 '24 23:05 kyleboyle

This branch works well on my side.

fgervais avatar Jun 29 '24 13:06 fgervais

Is this repository / project dead? Is there a replacement project?

Someone made one: https://github.com/henriquegemignani/PyQtDarkTheme. The issues tab isn't open though.

mak448a avatar Aug 07 '24 03:08 mak448a

Hi @henriquegemignani, I see you included this PR in your fork and published it on PyPI. Are you interested in maintaining that fork, and accepting issues and PRs? It seems like there are others here (including myself) who are willing to help keep this going.

JWCook avatar Aug 13 '24 19:08 JWCook

If you open a PR I'm ok with merging and releasing, but I don't plan on doing more than maintenance that lets me keep upgrading PySide and Python.

henriquegemignani avatar Aug 13 '24 19:08 henriquegemignani

That's fair. Thanks for the reply!

JWCook avatar Aug 13 '24 19:08 JWCook

@henriquegemignani Could you enable issues on your repo?

mak448a avatar Aug 13 '24 22:08 mak448a

@mak448a Sure, but I don't really see an use.

henriquegemignani avatar Aug 15 '24 13:08 henriquegemignani