laravel-notion-api icon indicating copy to clipboard operation
laravel-notion-api copied to clipboard

Laravel 11.x Compatibility

Open laravel-shift opened this issue 1 year ago • 4 comments

This is an automated pull request from Shift to update your package code and dependencies to be compatible with Laravel 11.x.

Before merging, you need to:

  • Checkout the l11-compatibility branch
  • Review all comments for additional changes
  • Thoroughly test your package

If you do find an issue, please report it by commenting on this PR to help improve future automation.

laravel-shift avatar Mar 02 '24 00:03 laravel-shift

:warning: The latest version of Laravel has a dependency for phpunit/phpunit of ^10.5. If you would like to also upgrade your tests, you may run the PHPUnit 10 Shift for free.

laravel-shift avatar Mar 02 '24 00:03 laravel-shift

:warning: Shift detected GitHub Actions which run jobs using a version matrix. Shift attempted to update your configuration for Laravel 11. However, you should review these changes to ensure the desired combination of versions are built for your package.

laravel-shift avatar Mar 02 '24 00:03 laravel-shift

:alembic: Using this package? If you would like to help test these changes or believe them to be compatible, you may update your project to reference this branch.

To do so, temporarily add Shift's fork to the repositories property of your composer.json:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/laravel-shift/laravel-notion-api.git"
        }
    ]
}

Then update your dependency constraint to reference this branch:

{
    "require": {
        "fiveam-code/laravel-notion-api": "dev-l11-compatibility",
    }
}

Finally, run: composer update

laravel-shift avatar Mar 02 '24 00:03 laravel-shift

PR Summary

  • Expansion of Triggered Events The workflow configuration now recognizes more actions. It will activate not only when code is manually pushed, but will respond to other workflow actions.

  • Broadened Compatibility The system compatibility range has been expanded. Additional versions of PHP, Laravel, and Testbench have been included, ensuring our service works smoothly across more systems.

  • Inclusive Updates Additional versions for Laravel and Testbench have been included for testing purposes, making sure every potential use-case has been catered to.

  • Preventive Measures Certain combinations of older PHP versions with newest Laravel version have been excluded from testing to prevent unlikely compatibility.

  • Support Added Support for a newer version of illuminate/support has been added to the program's core features, ensuring our product stays up to date.

  • Development Tools Updates Important updates have been made in the development tools section. They now include latest versions for the test environment, enabling an efficient and thorough testing process.

what-the-diff[bot] avatar Mar 02 '24 00:03 what-the-diff[bot]

Any chance getting this PR merged? Would love to use this in a new Laravel 11 project.

hermanschutte avatar Apr 19 '24 11:04 hermanschutte

Any chance getting this PR merged? Would love to use this in a new Laravel 11 project.

I'm having a look into this and trying to merge this soon.

johguentner avatar Apr 19 '24 11:04 johguentner

With #174 laravel-notion-api (v1.2.0) supports Laravel 11.x

  • all tests are running smoothly and I tested various scenarious directly with the Notion API
  • if you find any issues, while running laravel-notion-api with Laravel 11.x, please open an issue and description what happened; thank you!

johguentner avatar May 05 '24 04:05 johguentner