OpenMLDB icon indicating copy to clipboard operation
OpenMLDB copied to clipboard

udf test for `unix_timestamp("")` might fail

Open aceforeverd opened this issue 2 years ago • 4 comments

/home/runner/work/OpenMLDB/OpenMLDB/hybridse/src/udf/udf_test.h:172: Failure
Expected equality of these values:
  expect
    Which is: Nullable{value=1674015278, type=int64}
  output
    Which is: Nullable{value=1674015279, type=int64}

refer https://github.com/4paradigm/OpenMLDB/actions/runs/3945482097/jobs/6752411020#step:7:21561

Fail might happen due to slow execution.

aceforeverd avatar Jan 30 '23 06:01 aceforeverd

I guess time in a range (e.g 5s) should be fine. mark as godd-first-issue. see https://github.com/4paradigm/OpenMLDB/blob/e19f12cdf886ae7fc595e2c4e133bec9602b344f/hybridse/src/codegen/udf_ir_builder_test.cc#L940-L941

aceforeverd avatar Jan 30 '23 07:01 aceforeverd

Can i contribute of this project?

Geeks-Arpan avatar May 20 '23 07:05 Geeks-Arpan

Can i contribute of this project?

sure

aceforeverd avatar May 21 '23 14:05 aceforeverd

Hi @Geeks-Arpan , would you like to fix this simple issue recently?

tobegit3hub avatar Feb 21 '24 08:02 tobegit3hub