prometheus-api-client-python icon indicating copy to clipboard operation
prometheus-api-client-python copied to clipboard
verified publisher icon 4n4nd

Add optional auth parameters for requests

Open ugurzongur opened this issue 3 years ago • 1 comments

Addresses #244

ugurzongur avatar Aug 10 '22 12:08 ugurzongur

@ugurzongur this looks great! But I don't really know how to test it since I don't have access to an amazon instance. Do you have any suggestions? Could you also please add a mock test if possible?

4n4nd avatar Aug 15 '22 16:08 4n4nd

FWIW I've tested this and was able to pull metrics from my AMP Workspace. This looks good to me and I'd be very happy to have this functionality available.

ntabris avatar Oct 06 '22 20:10 ntabris

Now that I think about it, the changes seem simple enough that we can merge them.

4n4nd avatar Oct 31 '22 16:10 4n4nd