GDevelop icon indicating copy to clipboard operation
GDevelop copied to clipboard

[$30.00 bounty] Allow shape painter objects to use anti-aliasing

Open tristanbob opened this issue 3 years ago • 6 comments

Description

Drawing circles (and other curved shapes) with shape painters results in jagged lines. This is true even with the default setting of anti-aliasing enabled for GDevelop projects.

Solution suggested

Pixi does support anti-aliasing and the circles look much better with it turned on.

Pixi with anti-aliasing = FALSE https://codepen.io/tristanbob/pen/VwQOrLP

Pixi with anti-aliasing = TRUE https://codepen.io/tristanbob/pen/GRQaOJM

  • [ ] GDevelop should offer the option to enable antialiasing on shape painter objects (and enabled by default, unless there are significant downsides)

tristanbob avatar Jun 21 '22 03:06 tristanbob

4ian has contributed $20.00 to this issue on Rysolv.

The total bounty is now $20.00. Solve this issue on Rysolv to earn this bounty.

rysolv-bot avatar Jun 22 '22 14:06 rysolv-bot

Silver-Streak has contributed $10.00 to this issue on Rysolv.

The total bounty is now $30.00. Solve this issue on Rysolv to earn this bounty.

rysolv-bot avatar Jun 23 '22 08:06 rysolv-bot

I would like to dabble into this. But first I have some doubts After browsing thorugh the code a bit, I found that the setting in the project properties changes the rendering setting for the textures and the renderer's antialiesing option is always set to false (My understanding might be completely wrong). Is there a reason for this?

After testing I did find that that the shape painter is being antialiesed, but not very well.

My idea is to completely use the renderer for antialiesing. I am worried if it might break some settings.

:)

Midhil457 avatar Jul 16 '22 08:07 Midhil457

Yeah but they want it enabled and currently no way to do that. Adding it to the settings is just tedious due to how the client is formed. You have to find a good place to pass it down.

jposeyjr avatar Jul 16 '22 14:07 jposeyjr

Yeah but they want it enabled and currently no way to do that. Adding it to the settings is just tedious due to how the client is formed. You have to find a good place to pass it down.

I didn't understand. Could you clarify?

Midhil457 avatar Jul 17 '22 15:07 Midhil457

Hello? Is it ok if I go forward with my plan?

Midhil457 avatar Jul 30 '22 13:07 Midhil457

Hey ! I worked a bit on that issue and I implemented something that looks I'd say prommessing ! Sending a PR today :)

Oxey405 avatar Nov 05 '22 13:11 Oxey405

Antialiasing can be heavy. I guess, the cacheAsBitmap mode will be interesting to allow to render high quality still images and keep good efficiency. https://pixijs.download/dev/docs/PIXI.Graphics.html#cacheAsBitmap

D8H avatar Nov 05 '22 17:11 D8H

@D8H I'vhe worked on it can you maybe look at it later ?

Oxey405 avatar Nov 05 '22 18:11 Oxey405

@D8H I'vhe worked on it can you maybe look at it later ?

I'm not sure what you mean. Do you want that I do a review?

D8H avatar Nov 05 '22 18:11 D8H

@D8H I'vhe worked on it can you maybe look at it later ?

I'm not sure what you mean. Do you want that I do a review?

Yes you guessed it :)

Oxey405 avatar Nov 05 '22 18:11 Oxey405

@ClementPasteau so my PR closes this issue and thanks for the merge :)

Oxey405 avatar Mar 24 '23 16:03 Oxey405

Fixed in #4509

ClementPasteau avatar Mar 24 '23 16:03 ClementPasteau

@rysolv-bot scan this please

Oxey405 avatar Mar 29 '23 06:03 Oxey405