image.nvim icon indicating copy to clipboard operation
image.nvim copied to clipboard

Published 20 hours ago • verified publisher icon 3rd

Image still shown when switching to a different tmux session

Open shurensha opened this issue 1 year ago • 15 comments

How to reproduce:

  1. setup two tmux sessions (not windows)
  2. minimal config on first to display image
  3. prefix+L to navigate to second
  4. image is still displayed

Possibly related to: #106

tmux 3.4 kitty 0.35.2 nvim v0.10.0 image.nvim 61c76515cfc3cdac8123ece9e9761b20c3dc1315

set -gq allow-passthrough on
set -g visual-activity off

screenshots

session 'notes'

image

session 'image_nvim'

image

shurensha avatar Jul 24 '24 05:07 shurensha

same problem, and also same nvim version and tmux version

edte avatar Jul 24 '24 06:07 edte

same problem, and also same nvim version and tmux version

try my PR if it fixes it on your end

shurensha avatar Jul 24 '24 10:07 shurensha

Same issue on wezterm. The PR does not fix this, unfortunately. Please let me know if I should open a separate issue for wezterm.

jborbik avatar Aug 12 '24 13:08 jborbik

can you try this branch? https://github.com/3rd/image.nvim/tree/pr/199 branch is pr/199 it's not merged yet

3rd avatar Aug 15 '24 10:08 3rd

Yes, it still happens on the pr/199 branch. I am using the default image.nvim config.

jborbik avatar Aug 15 '24 15:08 jborbik

Same problem, tried with pr/199 branch, to no avail.

davidfmatheson avatar Oct 01 '24 01:10 davidfmatheson

This was fixed by @maxbol in https://github.com/3rd/image.nvim/pull/221 :pray:

3rd avatar Oct 02 '24 08:10 3rd

My PR was against the 199 branch, not sure if you noticed, but I think you might have merged it into that and then closed that branch @3rd ? 😀

maxbol avatar Oct 02 '24 10:10 maxbol

ah crap, sorry about that

3rd avatar Oct 02 '24 10:10 3rd

Woohoo, this worked. Much appreciated.

davidfmatheson avatar Oct 02 '24 16:10 davidfmatheson

@davidfmatheson May I ask you how does it worked? Mine still got a overlapped when I switch between tabs or sessions. I'm already on the 88e9693 commit now.

KilinW avatar Oct 07 '24 00:10 KilinW

@davidfmatheson May I ask you how does it worked?

I ran Lazy and updated the plugin, navigated to a markdown file with an image referenced, moved the cursor to that line, saw the image, left the cursor there and brought up my mix session picker (<leader>s for me), navigated to a different session, the image went away. It also goes away if I switch windows within a session.

I would note the image stayed visible on the session picker screen, but progress!

davidfmatheson avatar Oct 07 '24 14:10 davidfmatheson

I think it's the best we can do for now, other than hiding the images on focus lost, but that would not be pleasing either :joy:

3rd avatar Nov 02 '24 13:11 3rd

I still see this issue on the latest version. Has the fix been merged to master?

LostLaplace avatar Mar 21 '25 20:03 LostLaplace

I still saw this problem up until I switched to snacks image.

davidfmatheson avatar Mar 21 '25 21:03 davidfmatheson