msgpack-rust icon indicating copy to clipboard operation
msgpack-rust copied to clipboard

Performance tweaks

Open 3Hren opened this issue 8 years ago • 1 comments

Currently there are performance issues due to indirection between decoding a marker and a value itself; and non-inlining in the core RMP crate. Need to write benchmarks and fix them. The one approach is to mark some functions as [inline] or [inline(always)]. This works, but I feel it a little bit hacky. The other one - is to match for marker bytes directly and avoid using read_marker, but we lose an abstraction then.

3Hren avatar Aug 27 '17 11:08 3Hren

IMHO #[inline] is not hacky, the attribute is essentially mandatory to allow inlining across crates.

arthurprs avatar Nov 28 '17 19:11 arthurprs