jspaint
jspaint copied to clipboard
Manage Storage bug: If initially there is no images in storage it displays "All Clear!"
Fresh session:

This is because there is a redundant condition at the end of storage manager function
if($table.find("tr").length == 0){
$message.html("<p>All clear!</p>");
}
This is handled in the the remove button onclick function. The storage manager should display the initial message which is
var $message = $(E("p")).appendTo($storage_manager.$main).html(
"Any images you've saved to your computer with <b>File > Save</b> will not be affected."
);
But a quick pr would fix this
This was intentional (that's why it's "All clear!" and not "All cleared!" for instance), but the intent was also to provide a better message for this case in the future. It would be good to include the reassuring message... in fact... that should just be separate and always be visible in the storage manager. So e.g. split $message into two things: an $empty_message that's initially empty, right after the $table in the DOM so it can visually replace it and then a $file_save_message that's just always visible at the bottom of the window.
The $empty_message could say "All cleared!" when removing the last item, and maybe something like "There's nothing here." for the initial state when there are no sessions.
Oh gotcha. I did not notice the difference between the All clear and All cleared!.
That would make it more clear for users I think.