intellij-language-1c-bsl icon indicating copy to clipboard operation
intellij-language-1c-bsl copied to clipboard

DRAFT. Реанимация плагина

Open theshadowco opened this issue 9 months ago • 5 comments
trafficstars

theshadowco avatar Feb 10 '25 15:02 theshadowco

[!IMPORTANT]

Review skipped

Review was skipped due to path filters

:no_entry: Files ignored due to path filters (1)
  • src/main/resources/META-INF/plugin.xml is excluded by !**/*.xml

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

В данном пулреквесте проведены изменения в конфигурации сборки проекта и обновления исходного кода. Обновлены версии плагинов, зависимости, репозитории, настройки Gradle и обвязка Gradle Wrapper. Скрипты запуска (gradlew/gradlew.bat) улучшены с точки зрения POSIX-совместимости и обработки аргументов. Во многих Java‑файлах изменена информация об авторских правах, а также внесены изменения в импорты и сигнатуры методов для повышения безопасности типов. Добавлена новая функциональность для интеграции языкового сервера через созданную фабрику и переработанный провайдер подключения.

Changes

Файлы Описание изменений
build.gradle.kts, gradle.properties, gradle/wrapper/gradle-wrapper.properties Обновление версий плагинов, изменение зависимостей, обновление репозиториев, обновление Java-совместимости, добавление новых свойств и параметров Gradle.
gradlew, gradlew.bat Улучшение POSIX-совместимости, переработка логики аргументов, улучшение обработки ошибок и обновление лицензии/отступов.
settings.gradle.kts, .idea/.name Изменение имени проекта.
BSLCommenter.java, BSLIcons.java, BSLLanguage.java, BSLConfigurableGUI.java, DiagnosticLanguage.java, LanguageServerSettingsState.java, TestUtils.java Обновление информации об авторских правах: расширение диапазона лет, смена имени автора.
BSLPairedBraceMatcher.java, BSLParserDefinition.java, BSLSyntaxHighlighter.java Обновление импортов (переход на новый ANTLR‑адаптер), улучшения типизации (@NotNull), изменение сигнатур методов, добавление новых конструкций и ключевых слов.
BSLFileType.java, OSFileType.java Добавление метода getDisplayName() для корректного отображения типа файлов, обновление данных об авторских правах.
BSLParserTest.java, Hello.txt Комментирование содержимого тестового класса, изменение регистра идентификаторов в тестовом файле.
BSLConfigurable.java Изменение объявления переменной state на final для обеспечения неизменности.
BSLLanguageServerFactory.java, BSLLanguageServerStreamConnectionProvider.java Добавление новой фабрики для создания подключения к языковому серверу и переработка логики формирования командной строки, обновление импортов и логирования.

Sequence Diagram(s)

sequenceDiagram
    participant IDE as "IDE Plugin Manager"
    participant Factory as "BSLLanguageServerFactory"
    participant Provider as "BSLLanguageServerStreamConnectionProvider"
    participant App as "ApplicationManager"

    IDE->>Factory: createConnectionProvider(project)
    Factory->>Provider: Создание нового провайдера
    Provider->>App: Получение LanguageServerSettingsState
    Provider->>Provider: Построение командной строки с параметрами и конфигурацией
    Provider->>IDE: Возврат настроенного подключения к языковому серверу

Poem

Привет! Я кролик с весёлым кодом,
В прыжке обновлений и радости поток.
Плагины сверкают, как звёзды в ночи,
Скрипты шевелятся, как уши у меня.
Пусть сборка мчится легко, как ветер в поле,
И ошибки бегут, не оставив следа!
🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

coderabbitai[bot] avatar Feb 10 '25 15:02 coderabbitai[bot]

@coderabbitai review

theshadowco avatar Feb 10 '25 15:02 theshadowco

:white_check_mark: Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot] avatar Feb 10 '25 15:02 coderabbitai[bot]

Greetings. I've accidentally stumbled upon your account and saw this MR.

You might be interested in this: https://github.com/redhat-developer/lsp4ij

Couple of months ago Redhat released a generic system to support all the lsps in all the Intellij's IDEs, including community ones. Yes, even with a debugger.

Its not perfect by any means, but probably would be faster to utilize this to some extent than resurrect 10 years old java plugin.

nev3rfail avatar Mar 23 '25 03:03 nev3rfail

Hi, @nev3rfail! Thanks for the heads up! If you look into my latest commits in this branch, you could see that I already migrated it to redhat solution. However LSP itself is not enough for bsl plugin, so it needs to contain some other basic features.

nixel2007 avatar Mar 23 '25 07:03 nixel2007