headstartwp icon indicating copy to clipboard operation
headstartwp copied to clipboard

Added a pre-packaged cookie dialog component

Open bmarshall511 opened this issue 2 years ago • 4 comments
trafficstars

Description of the Change

Added a pre-packaged cookie acceptance dialog component, see #419.

@nicholasio We'll probably need to move this or replicate it across the other workspaces, but before I do that, wanted to see if this was what you were thinking for the pre-packaged cookie dialog.

Closes #419

How to test the Change

  1. Add the CookieDialog component on a page
  2. Visit the page and click either the accept or deny buttons
  3. Check dev tools for the cookies that have been set
  4. Reload the page to ensure the dialog doesn't reappear
  5. Delete the cookie-dialog-reviewed cookie & reload the page to confirm the dialog reappears

Changelog Entry

Added - Pre-packaged cookie dialog component

Credits

Props @bmarshall511

Checklist:

  • [x] I agree to follow this project's [Code of Conduct]

bmarshall511 avatar Jun 16 '23 20:06 bmarshall511

⚠️ No Changeset found

Latest commit: fc7736fb04f49a058b0cf5cb49c9a8f9394aa769

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 16 '23 20:06 changeset-bot[bot]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
headstarwp ✅ Ready (Inspect) Visit Preview Jun 16, 2023 8:11pm

vercel[bot] avatar Jun 16 '23 20:06 vercel[bot]

📦 Next.js Bundle Analysis for @10up/headless_framework

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

github-actions[bot] avatar Jun 16 '23 20:06 github-actions[bot]

Thanks for the PR! I'll spend some time reviewing this next week.

nicholasio avatar Jun 22 '23 21:06 nicholasio