action-wordpress-plugin-deploy icon indicating copy to clipboard operation
action-wordpress-plugin-deploy copied to clipboard

set-output command deprecated in last release

Open julienloizelet opened this issue 2 years ago • 4 comments

Describe the bug

Hi, and thanks for this useful action :)

When running the last 2.1.1 release, there is a warning :

The set-output command is deprecated and will be disabled soon. Please upgrade to using Environment Files. For more information see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

Reading the content of the link to follow, we have :

Starting 1st June 2023 workflows using save-state or set-output commands via stdout will fail with an error.

I saw that it has been fixed in this commit : https://github.com/10up/action-wordpress-plugin-deploy/commit/c85e3f4212e9b58b3c617b9715a4d941ae002a4d

Is it possible to have a new release that include this commit (or to schedule one before June)?

Steps to Reproduce

  1. Run the 2.1.1 version

Expected behavior No warning

Additional context

julienloizelet avatar Mar 23 '23 02:03 julienloizelet

@julienloizelet thanks for the detailed report, I'll see if we've got someone that can work on a fix for this but would otherwise be open to anyone else able to contribute a PR as well

jeffpaul avatar Mar 23 '23 13:03 jeffpaul

Hi @jeffpaul, fix is already done with this commit https://github.com/10up/action-wordpress-plugin-deploy/commit/c85e3f4212e9b58b3c617b9715a4d941ae002a4d

It would be enough to publish a release integrating this commit.

Thanks

julienloizelet avatar Mar 24 '23 05:03 julienloizelet

@jeffpaul could you merge that commit when you have time? End of this month, the plugin will no longer work because of the deprecation of the set-output function.

adriaandotcom avatar May 02 '23 13:05 adriaandotcom

@jeffpaul Think this one can be closed, I see the https://github.com/10up/action-wordpress-plugin-deploy/commit/c85e3f4212e9b58b3c617b9715a4d941ae002a4d change in both the develop and stable branches.

bmarshall511 avatar Jun 22 '23 14:06 bmarshall511