ethmonitor: review behaviour if Options.LogTopics is defined

Open attente opened this issue 3 years ago • 2 comments

https://github.com/0xsequence/ethkit/blob/7d9af4e211c25a5533b8e66195706ae1602fe22f/ethmonitor/ethmonitor.go#L324-L347

I haven't tried this, but I think if topics are specified, then it's possible to receive no logs, while the logs bloom filter is non-zero. This means the block is never considered backfilled and causes the monitor to hang if logs are requested.

Aug 19 '22 15:08 attente

I'm facing this exact issue. My topics slice is non-empty and the monitor hangs after encountering a block without any matching logs (as per topics filter)

Apr 26 '23 10:04 0xbsa

Why is this check required at all? https://github.com/0xsequence/ethkit/blob/7d9af4e211c25a5533b8e66195706ae1602fe22f/ethmonitor/ethmonitor.go#L337

Apr 26 '23 10:04 0xbsa