Tim Condon comments

Results 525 comments of


                                            Tim Condon

Allow introspection of Rows by making PostgresRow.lookupTable readable

I see no reason not to make it public - it seems like a reasonable use case. @gwynne Any objections?

Massive 100% CPU load when receiving multi frame WebSocket message

Are you testing this is release mode or debug mode?

Serialization seems to contain wrong data

@dalu93 are you seeing this in the latest release? We've rewritten the parser in Swift so hopefully this issue has been resolved

Crash on multipart/form-data decoding with empty mime type.

Moving to here to track it

Add More OAuth Providers

@natebird see #19 for a Facebook integration - I _think_ it works. As for the second question, see #24 !

Auth0 support missing

Looks like it got missed off between the Vapor 4 release and being merged into the Vapor 3 branch. It should be simple enough to add if anyone wants to...

Maybe it is possible to update Imperial to async/await?

Yep it should probably be done at some point but will likely need someone to step up and do it

Session access token encoding error for Facebook callback

Hmm that's weird. I wonder if it's a Fluent issue 🤔 The only way that line could fail would be if it's trying to set invalid data to JSON. Is...

Value required for key 'access_token'.

Reopening as Imperial should handle this better regardless of what global settings people have

Missing code key in url query

What version of Imperial do you have in your Package.swift and what does your setup code look like? I've just built an app using Sign in With Google and it's...