Tim Condon

Results 526 comments of Tim Condon

Just an FYI I'm going to be doing an Imperial code sprint next week to go through all the issues and PRs

I believe this is caused by Swift Concurrency and the use of the thread safe wrapper. In normal code, since we're event loop based we don't hit that, but that's...

Yep that's how I discovered this when updating the template

Waiting on https://github.com/vapor/console-kit/pull/198 to discuss if we can test this in CI

Need to work out why the configuration has broken in the tests

Verified this works with https://github.com/vapor/template/pull/131 with Leaf and Fluent and all working

@gwynne this is ready for you now I think

I think we (the SSWG) can raise this at the next meeting for discussion, there's enough people there that it affects and that can help with work

Nope must have gotten lost, will add it to the agenda for the next meeting

We also need to account for the system setting changing - see https://stackoverflow.com/questions/59621784/how-to-detect-prefers-color-scheme-change-in-javascript