Tim Condon

Results 527 comments of Tim Condon

Can you push the current test case up?

@Kithin you're using the new generics syntax from Swift 5.7 that isn't available on older Swift versions. You'll need to find a work around

@Kithin It's in the application tests, I can't see the test you added anymore?

@Kithin Hmm I see. I can't check the merge conflicts because I don't have access to the fork. So the easiest thing to probably do is close the PR, update...

@SpaceboatDVLP that pattern would be to store the instance of the `SpyClient` on the `XCTestCase` So in your test case you'd do ```swift self.spyClient.stubResponse(httpStatus: .ok, responseData: response) ``` That allows...

One point for comment is it might be worth defaulting to making service access `async` to avoid immediately deprecating everything when #2873 lands

To add some further context, the original code (the generic `Service` stuff) was taken from a Vapor 4 project that's been running in production for over 2 years with no...

@Joannis what do you mean?

@makhocheung it's commented out because there was an issue with the concurrency/NIO integration for making it work. Feel free to try adding it though!