David Revelo

Results 23 comments of David Revelo
trafficstars

Hi @TomasBarry , have you checked if the message you are trying to customize is among the [translations file](https://github.com/graphql-devise/graphql_devise/blob/master/config/locales/en.yml)? If so, you can [overwrite it](https://phrase.com/blog/posts/rails-i18n-guide/) on your project.

Hey @stevehodgkiss, thanks! So the problem appears on [this spec](https://github.com/graphql-devise/graphql_devise/blob/master/spec/generators/graphql_devise/install_generator_spec.rb#L27) which is why the spec is commented for now. The spec is using [this generator](https://github.com/graphql-devise/graphql_devise/blob/master/lib/generators/graphql_devise/install_generator.rb#L8). The [mount_resource_route](https://github.com/graphql-devise/graphql_devise/blob/master/lib/generators/graphql_devise/install_generator.rb#L16) method in the...

Just run into the same issue and @ttseng fix worked for me, are you planning to fix this anytime soon or accepting PRs for this?

Will take a look tomorrow @natematykiewicz :)

Hi @gmaliar , the biggest problem this PR has is that the feature is not officially approved, that's why I haven't continue working on it. Here is the [rails forum...

Hi @jorge-precich , I do started this PR based on that issue that @jrochkind mentioned and would definitely love any feedback or advice from @matthewd . I guess that maybe...

@natematykiewicz @jrochkind @deepj I will rebase against the last changes in master to prevent it from being closed. I'm not sure what we can do get the attention of a...

You are correct @md5 , I based my implementation in `insert_all`. I see where you are coming from for this suggestion, nevertheless not sure making the change will do anything...

Hi @zzak thanks so much for checking this! Is there something I have to/can do about the `Need a review on this implementation` part or is this an rails team...

Understood @zzak , thanks for clearing this up. I guess nothing to do but wait for this to reach @matthewd 's radar.